Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring quiet_assets to sprockets-rails #338

Closed
wants to merge 1 commit into from

Conversation

route
Copy link

@route route commented Apr 2, 2016

As discussed here rails/rails#24383 out of DHH comment here evrone/quiet_assets#47 (comment)
Again feel free to direct me and I'll fix everything that needs to be

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@maclover7
Copy link
Contributor

In general, 👍 on this. Would you be able to add a test case or two to test this functionality?

@route
Copy link
Author

route commented Apr 4, 2016

@maclover7 yep will do that

@connorshea
Copy link
Contributor

👍 nice! Wasn't sure how to implement this myself, so I'm glad you picked it up! Thank you!

@connorshea
Copy link
Contributor

@maclover7 would you be alright with adding this to the 5.0.0 milestone? Or 5.1.0 at least.

@route any updates on those tests? :)

@maclover7
Copy link
Contributor

@connorshea I don't think adding to a 5.x milestone is necessary -- as far as I can tell, this isn't a release blocker, but more of a new feature being added.

@connorshea
Copy link
Contributor

@route any progress on this?

@connorshea
Copy link
Contributor

@maclover7 Is there any policy on picking up and finishing abandoned pull requests like this?

@route
Copy link
Author

route commented Jun 2, 2016

Sorry guys, I'll try to make it this weekend, too many things. If not feel free to pick it up

@kmcphillips
Copy link
Contributor

This is great 👍

@rafaelfranca
Copy link
Member

rafaelfranca commented Jun 9, 2016

Thanks! Merged in #355

@connorshea
Copy link
Contributor

@rafaelfranca I think you mean #355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants