Do not fingerprint if filename contains a valid digest

[brenogazzola]

As discussed in rails/jsbundling-rails#15, this PR prevents Sprockets from fingerprinting an asset that already contains a valid digest in its name.

It does that by changing digest_path in Asset to return logical_path if @name contains a sequence of characters whose unpacked bytesize matches that of one of the valid digest classes

[dhh]

This is great. How convenient that we already had all the machinery to detect a valid hash!

[brenogazzola]

Changelog added. I also had to change the regex because it was not recognizing .chunk.js files which the bundlers like to generate

[brenogazzola]

In the end it was not necessary to consider .chunk since we can control it from jsbundling side and keep the code cleaner.

[dhh]

@rafaelfranca Think we could cut a point release of sprockets for this?

[tsrivishnu]

We are migrating from Webpacker to jsbundling-rails. Currently, this is the only thing that is keeping us from going to production with jsbundling-rails.
@rafaelfranca consider making a release of sprockets with this.

[Vannsl]

Great work, thank you! Is there an update on the release? We need this package for migration. @rafaelfranca @brenogazzola @dhh

[dhh]

You don't need anyone's release or permission to use this code! Just bundle directly: gem "sprockets", github: "rails/sprockets", ref: "cddf9fb841eece80276a1ccaee1e018a356547a0".

[tsrivishnu]

I suppose the goal of the comments was to also show that the community is looking forward to having these changes released.

[rafaelfranca]

Yeah. I think we can release a minor release for this change. I'll do it

[Vannsl]

Thank you @rafaelfranca, that's a lovely christmas present!

[joker-777]

@rafaelfranca It would amazing if you could release this change officially.