Ensure compatibility with esbuilds' base32 digests

[dhh]

esbuild hashes using base32, so we can configure it to produce files like application-TQDC3LZV.digested.js, but we need the digest patterns to accept this. That requires changing the digest matching pattern from /-([0-9a-f]{7,128})\.[^.]+\z/ to /-([0-9a-zA-Z]{7,128})\.[^.]+\z/.

[strobilomyces]

Just curious if there's anything preventing this from being merged. Thank you.

[cirdes]

Sprockets is supporting webpack digest but we need this PR merged to support esbuilds too. Hope it could be merge!

[markets]

@rafaelfranca @dhh sorry for the ping 🙏🏼 but would be amazing to merge and release this one! Is there anything missing? It has already been merged on Propshaft: rails/propshaft#55.

Sorry again and thanks a lot for building & maintaining Rails 🙌🏼

[ylecuyer]

I have an issue when running https://github.com/FabienChaynes/faye-authentication and another similar gem called faye-presence with this commit.

They have assets which are now matching the pattern and which get stripped out in the sprocket server. Any recommendation on how to get the assets being served with the changes in this PR?

[schneems]

This caused a regression mentioned in this blog post https://evgeniydemin.medium.com/breaking-change-during-rails-upgrade-introduced-by-david-heinemeier-hansson-80262129c7f1

In the blog post anything-supercool.svg was being viewed by sprockets as already having a digest because of the change in the server regexp:

• Server regex before: https://rubular.com/r/eqlVqN7FZnaS1v
• Server regex after: https://rubular.com/r/tMRxDTxKw4iWk9

This causes sprockets to look for assets/anything-supercool.svg instead of doing a lookup for the digest in the manifest and looking for assets/anything-supercool-<digest>.svg