Lowercase all response headers #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatsuda
added a commit
to amatsuda/sprockets
that referenced
this pull request
Apr 1, 2022
Rack::Lint 3 requires all response headers to be lower-cased see: rack/rack#1592 s/Content-Type/content-type/g s/Content-Length/content-length/g s/Cache-Control/cache-control/g s/ETag/etag/g s/Vary/vary/g s/X-Cascade/x-cascade/g
amatsuda
force-pushed
the
lowercase_headers
branch
from
35c7bd7
to
cdab3b8
Compare
|
Thank you this looks great. |
mishina2228
added a commit
to mishina2228/web-console
that referenced
this pull request
Jun 8, 2022
The latest rack 3.0 (unreleased) does not accept uppercase headers. See rack/rack#1592 for more details. refs: - rack/rack#1812 - rails/sprockets#744
mishina2228
added a commit
to mishina2228/web-console
that referenced
this pull request
Jun 9, 2022
The latest rack 3.0 (unreleased) does not accept uppercase headers. See rack/rack#1592 for more details. refs: - rack/rack#1812 - rails/sprockets#744
|
This commit has a considerable impact on performance, see #746 |
patrickm68
added a commit
to patrickm68/web-console
that referenced
this pull request
Dec 1, 2022
The latest rack 3.0 (unreleased) does not accept uppercase headers. See rack/rack#1592 for more details. refs: - rack/rack#1812 - rails/sprockets#744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rack::Lint requires all response headers to be lower-cased since rack/rack@472e12f, and the CI here is failing due to that change. So here are fixes on Sprockets::Server to comply with the Rack::Lint change and make the CI green again.
See rack/rack#1592 for more details.
/cc @ioquatix @jeremyevans