Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_file should unlink broken symlinks #720

Merged

Conversation

2called-chaos
Copy link
Contributor

The problem is that remove_file only checks if File.exist? which is false if the symlink target does not exist (anymore). In create_link this was already considered.

Copy link

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rafaelfranca rafaelfranca merged commit 2c1d3c0 into rails:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants