Update default extensions and move to installer #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javan
reviewed
Jan 14, 2018
| @@ -12,6 +12,9 @@ | |||
| "environment.loaders.append('coffee', coffee)\n", | |||
| before: "module.exports" | |||
|
|
|||
| say "Updating webpack paths to include .coffee file extension" | |||
| insert_into_file Webpacker.config.config_path, " - .coffee\n", after: /extensions:\n/ | |||
There was a problem hiding this comment.
Inserting YAML like this at the corrected indentation level seems a little brittle. Do we do it this way elsewhere in Rails?
There was a problem hiding this comment.
Couldn't find any reference but this is how it's done in Rails: https://github.com/rails/rails/blob/63f0c04850dd0bcdc7d35266e81fa1a7778570a8/railties/lib/rails/generators/actions.rb#L326
May be we can borrow that method.
|
Do we use these extensions on the Ruby side anywhere? |
|
Nope we aren't using it internally. |
|
Merging this for now :) |
kawikadkekahuna
added a commit
to wealthfit/webpacker
that referenced
this pull request
Jan 29, 2018
* 'master' of https://github.com/rails/webpacker: (21 commits) Update Ruby versions on Travis CI (rails#1230) Make rubocop happy Fix asset helper for non-css assets in hmr mode CSP warning for Rails 5.2 use 2 spaces for indentation in template injection Update README.md (rails#1198) Remove duplicate yarn-error.log (rails#1197) 3.2.1 Revert file loader (rails#1196) Update default extensions and move to installer (rails#1181) Gitignore (rails#1195) Update uglify plugin (rails#1194) Fixes Vue root instance initialization (rails#1187) Return false in production environments (rails#1179) Fix url loader doc[ci skip] (rails#1183) Use inject_into_file to support rails 4.2 Update gems and npm deps (rails#1180) asset_pack_path + HMR fix; Closes rails#1171 (rails#1172) enhance CHANGELOG.md (rails#1170) CI against Ruby 2.5.0 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1148
This PR moves out extensions from webpacker.yml to specific installer.