Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Source maps in production, reverts #770 #1918

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Conversation

guilleiguaran
Copy link
Member

Copy link
Contributor

@javan javan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥🔭

@dhh dhh merged commit 1267acc into master Jan 28, 2019
@gauravtiwari gauravtiwari deleted the default-source-maps branch January 28, 2019 18:52
@connorshea
Copy link
Contributor

This should have a changelog entry (and possibly should be mentioned in the v4 upgrade doc as well).

Make sure to mention that it makes debugging in production easier, will be compressed by default, and shouldn’t increase the asset size by very much, as source maps aren’t loaded unless the dev tools are opened. :)

@wildjcrt
Copy link

@gauravtiwari hi, is there any way to change devtool for source map?

@gauravtiwari
Copy link
Member

@wildjcrt Sure, please see: https://github.com/rails/webpacker/blob/master/docs/webpack.md#configuration

// development.js or production.js

const environment = require('./environment')
environment.config.merge({ devtool: 'none' })

module.exports = environment.toWebpackConfig()

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants