Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workarounds for Yarn not playing nicely on Windows #584

Merged
merged 2 commits into from
Jul 24, 2017

Conversation

soundasleep
Copy link
Contributor

  • Bypass yarn run when running on Windows; instead, we can go directly to node_modules/.bin/
  • Create batch scripts so users don't need to type in ruby bin/webpack manually

See discussion on #583

- Bypass `yarn run` when running on Windows; instead, we can go directly
to `node_modules/.bin/`
- Create batch scripts so users don't need to type in `ruby bin/webpack`
manually

See discussion on rails#583
@gauravtiwari
Copy link
Member

@soundasleep Looks great 👍 🍰 Not sure about .bat scripts though. How do you run rails binstub on windows? ./bin/rails or ruby ./bin/rails?

Can we also document this in README and Changelog please?

@gauravtiwari
Copy link
Member

Lets drop .bat scripts (primarily because it's not uniform with other binstubs and isn't useful for non-window users). We can document this in README to use it as ruby ./bin/webpack

Do not generate batch files when installing
@soundasleep
Copy link
Contributor Author

Yup! That's a great idea. Updated the MR, and removed the batch scripts.

On Windows you don't tend to use any of the binstubs anyway, you'll use rails directly, as there's usually only a single version globally installed. e.g. http://railsinstaller.org/en

@gauravtiwari
Copy link
Member

Awesome 🍰 🎉 Looks great, thank you :)

Yeah, that makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants