Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turbo-rails 2 in gemspec #3671

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Allow turbo-rails 2 in gemspec #3671

merged 1 commit into from
Feb 12, 2024

Conversation

bb
Copy link
Contributor

@bb bb commented Feb 5, 2024

@coveralls
Copy link

Coverage Status

coverage: 95.9%. remained the same
when pulling f6c4523 on bb:patch-1
into af7414a on railsadminteam:master.

@mshibuya mshibuya merged commit d520219 into railsadminteam:master Feb 12, 2024
5 of 23 checks passed
@mshibuya
Copy link
Member

CI is failing, but I can handle it. Thanks!

@bb bb deleted the patch-1 branch February 12, 2024 10:18
@bb
Copy link
Contributor Author

bb commented Feb 12, 2024

Thank you!

@xijo
Copy link

xijo commented Jun 28, 2024

@pathakh any chance to release this soon-ish? Feels bad to force us all to stay on an outdated version of turbo :|

@bb
Copy link
Contributor Author

bb commented Jul 11, 2024

@mshibuya thanks for providing the hotfixes 3.1.3+4. Are there any plans to create a new minor release from master (which includes this PR)?

If not, could you please update the patch version in master to 3.1.4 so we can refer to master in our bundle without having to ignore GHSA-8qgm-g2vv-vwvc in our audits.

@mshibuya
Copy link
Member

I've just released a pre-release version 3.2.0.beta. The master was also bumped to that version.
It'll take some more time for the next minor release, but please give feedback so it can happen earlier 🙏

@bb
Copy link
Contributor Author

bb commented Jul 13, 2024

That's great, thank you! I tried 3.2.0.beta locally and in CI. Also converted an App from Sprockets to Ruby-Vite (thanks to #3643) which also works for me. Good to go, from my perspective. 🚀

Edit: there are some SASS deprecation warnings inside node_modules/bootstrap/scss/. Not a show-stopper but maybe good to know. They're addressed here: twbs/bootstrap#40623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants