Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a params to specify the docker cert path #1129

Closed
wants to merge 3 commits into from

Conversation

cchalop1
Copy link
Contributor

I made this PR to add a params to specify the docker cert path.

Tell me what you thinks about it ?

Do you have any idea to test it ?

@cchalop1 cchalop1 closed this Jun 29, 2024
@cchalop1 cchalop1 reopened this Jun 29, 2024
@coffee-cup
Copy link
Contributor

Hi @cchalop1, Thanks for the PR.

While I can see this as useful, I'm wondering about your use case and if running NIxpacks with the --out {dir} command would work for you. This outputs a Dockerfile and all the files that Nixpacks uses to generate a Docker build with. You can use this to run the docker command manually and include any config necessary.

Would this work? Not opposed to adding the arg to Nixpacks. But I worry about how much Docker config Nixpacks should import and simply pass on to Docker.

@coffee-cup coffee-cup added the release/patch Author patch release label Jul 16, 2024
Copy link
Contributor

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The pull request is stale label Jul 27, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

This pull request was closed for lack of activity. Feel free to reopen later.

@github-actions github-actions bot closed this Aug 1, 2024
@cchalop1
Copy link
Contributor Author

Sorry for my late response, I understand your point of view @coffee-cup. However, there is already a variable to specify a Docker host, called docker-host, so it would make sense to have another variable just for establishing a secure connection with this host, wouldn't it?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/patch Author patch release stale The pull request is stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants