Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change base image to ghcr.io/railwayapp/nixpacks:debian #113

Merged
merged 3 commits into from May 12, 2022
Merged

Change base image to ghcr.io/railwayapp/nixpacks:debian #113

merged 3 commits into from May 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2022

Changing base image will make builds faster and reproducible. Also, better log readability.

@ghost ghost marked this pull request as draft May 12, 2022 20:30
@ghost
Copy link
Author

ghost commented May 12, 2022

Will reopen after #106 is merged.

@ghost ghost marked this pull request as ready for review May 12, 2022 20:54
@coffee-cup
Copy link
Contributor

I think we need to install sudo here for the Haskell tests to pass https://github.com/railwayapp/nixpacks/blob/main/base/debian/Dockerfile#L4

@coffee-cup coffee-cup merged commit 1d5ba39 into railwayapp:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant