Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Haunt for Scheme as a provider #1198

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Add Haunt for Scheme as a provider #1198

merged 10 commits into from
Nov 13, 2024

Conversation

Siarune
Copy link
Contributor

@Siarune Siarune commented Sep 27, 2024

Creates and registers a build provider for Scheme with the static builder Haunt.
Adds a very basic example to test provider.
Adds docs

Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just a few minor comments

docs/pages/docs/providers/scheme.md Outdated Show resolved Hide resolved
tests/docker_run_tests.rs Outdated Show resolved Hide resolved
docs/pages/docs/providers/scheme.md Outdated Show resolved Hide resolved
@coffee-cup coffee-cup added the release/minor Author minor release label Oct 5, 2024
Copy link
Contributor

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The pull request is stale label Oct 16, 2024
@Siarune
Copy link
Contributor Author

Siarune commented Oct 19, 2024

My build plan commands seem out of order, and I can't tell why.

This is my plan definition:

let setup = Phase::setup(Some(vec![Pkg::new("haunt")]));
let build = Phase::build(Some("haunt build".to_string()));
let start = StartPhase::new("haunt serve".to_string());

let plan = BuildPlan::new(&vec![setup, build], Some(start));
Ok(Some(plan))

So this is what I'd expect the order to be:

╔════ Nixpacks v1.29.0 ════╗
║ setup      │ haunt       ║
║──────────────────────────║
║ build      │ haunt build ║
║──────────────────────────║
║ start      │ haunt serve ║
╚══════════════════════════╝

But this is what it actually is

╔════ Nixpacks v1.29.0 ════╗
║ build      │ haunt build ║
║──────────────────────────║
║ setup      │ haunt       ║
║──────────────────────────║
║ start      │ haunt serve ║
╚══════════════════════════╝

@github-actions github-actions bot removed the stale The pull request is stale label Oct 20, 2024
@coffee-cup
Copy link
Contributor

coffee-cup commented Oct 26, 2024

You can specify phase dependencies. By default the build phase depends on the install phase, but if there is no install you need to specify the dependency manually.

build.depends_on_phase("setup")

Copy link
Contributor

github-actions bot commented Nov 7, 2024

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The pull request is stale label Nov 7, 2024
@coffee-cup coffee-cup removed the stale The pull request is stale label Nov 8, 2024
@coffee-cup coffee-cup merged commit 6b61023 into railwayapp:main Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/minor Author minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants