Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(php): ignore multiple php extensions #1225

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

dnwjn
Copy link
Contributor

@dnwjn dnwjn commented Nov 14, 2024

Hi team!

I tried running a PHP Laravel application with nixpacks. In our composer.json we have "ext-zend-opcache": "*", which causes the following error in nixpacks:

#8 77.02        error: attribute 'zend-opcache' missing
#8 77.02        at /app/.nixpacks/nixpkgs-dbc4f15b899ac77a8d408d8e0f89fa9c0c5f2b78.nix:6:91:
#8 77.02             5|   let
#8 77.02             6|     APPEND_LIBRARY_PATH = "${lib.makeLibraryPath [ libmysqlclient phpExtensions.simplexml phpExtensions.zend-opcache phpExtensions.zip ] }";
#8 77.02              |                                                                                           ^
#8 77.02             7|     myLibraries = writeText "libraries" ''

Since the zend-opcache extension is included in PHP since 5.5, I figured this might be why this exception occurs, and also why it's not included in nix? I could at least not find anything about it in your docs.

Anyways, Rust is new to me, so if the code is incorrect or not up to your standards, don't hesitate to let me know!

Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome ty!

@coffee-cup coffee-cup added the release/patch Author patch release label Nov 15, 2024
@coffee-cup
Copy link
Contributor

Could you please fix the linting and compile errors. Should be able to debug locally with

cargo fmt --all -- --check
cargo check
cargo clippy

@dnwjn
Copy link
Contributor Author

dnwjn commented Nov 15, 2024

Could you please fix the linting and compile errors. Should be able to debug locally with

cargo fmt --all -- --check
cargo check
cargo clippy

Appreciate you sharing the commands, it should be all good now!

@coffee-cup coffee-cup merged commit 2d16cd9 into railwayapp:main Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/patch Author patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants