Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more py deps for audio and image processing #1271

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

iloveitaly
Copy link
Contributor

@iloveitaly iloveitaly commented Jan 21, 2025

  • Integrate ffmpeg-headless for handling audio dependencies when using pydub or pymovie.
  • Include poppler_utils to support PDF processing for pdf2image.

- Integrate `ffmpeg-headless` for handling audio dependencies when using `pydub` or `pymovie`.
- Include `poppler_utils` to support PDF processing for `pdf2image`.
Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@coffee-cup coffee-cup added the release/minor Author minor release label Jan 24, 2025
@coffee-cup
Copy link
Contributor

Could you please also add a test that uses these dependencies. I'm also not sure we should be adding something custom for pymovie. As far as I can tell it is a very small package with little documentation?

@iloveitaly
Copy link
Contributor Author

Could you please also add a test that uses these dependencies. I'm also not sure we should be adding something custom for pymovie. As far as I can tell it is a very small package with little documentation?

yeah we are using pydub, pymovie was one we looked into briefly so figured i'd add it but didn't realize it was so small. Will remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/minor Author minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants