Java provider #184
Merged
Java provider #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2022 18:56
ghost
marked this pull request as draft
Milo123459
reviewed
Jun 5, 2022
| } | ||
|
|
||
| fn detect(&self, app: &App, _env: &Environment) -> Result<bool> { | ||
| Ok(app.includes_file("pom.xml") |
There was a problem hiding this comment.
I thought scala, groovy, clojure etc were going in different providers?
There was a problem hiding this comment.
Also, Gradle should probably be supported.
There was a problem hiding this comment.
I am basically rewriting heroku's java buildpack. Will add/remove stuff later.
There was a problem hiding this comment.
I thought scala, groovy, clojure etc were going in different providers?
We're gonna do em as one for now and then work on composition once we get to parity
There was a problem hiding this comment.
Simplicity sake for now. Easier to break them up later once we know what the composition looks like than try to define abstractions across providers without knowing what should be composable.
added 2 commits
June 5, 2022 21:17
JakeCooper
reviewed
Jun 7, 2022
added 2 commits
June 7, 2022 03:35
JakeCooper
approved these changes
Jun 7, 2022
coffee-cup
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #111