Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
This just changes some regexes to be slightly cleaner & less hacky.
The notable change is that the node versoin Regex now only matches the semver major version. I noticed that we are only checking the major version, and there is no point in getting other captures if we don't need them.
Fixes # (issue)
Before submitting:
cargo test
?cargo fmt
,cargo check
andcargo clippy
locally to ensure that CI passes?