Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve on current regexes #371

Merged
merged 8 commits into from
Aug 2, 2022
Merged

Conversation

Milo123459
Copy link
Collaborator

@Milo123459 Milo123459 commented Jul 28, 2022

What does this PR address?

This just changes some regexes to be slightly cleaner & less hacky.

The notable change is that the node versoin Regex now only matches the semver major version. I noticed that we are only checking the major version, and there is no point in getting other captures if we don't need them.

Fixes # (issue)

Before submitting:

  • Make sure to follow GitHub's guide on creating PR.
  • Did you read through contribution guidelines?
  • Did your changes require updates to the documentation? Have you updated those accordingly?
  • Did you write tests to cover your changes? Did it pass locally when running cargo test?
  • Have you run cargo fmt, cargo check and cargo clippy locally to ensure that CI passes?

@Milo123459 Milo123459 marked this pull request as ready for review July 28, 2022 21:52
@Milo123459 Milo123459 requested a review from coffee-cup July 28, 2022 21:54
@Milo123459 Milo123459 changed the title Remove hackiness on node regex Improve on current regexes Jul 30, 2022
@coffee-cup coffee-cup merged commit 9f5fd65 into main Aug 2, 2022
@coffee-cup coffee-cup deleted the milo/remove-hackiness-on-node-regex branch August 2, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants