-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turborepo support #557
Turborepo support #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some changes to dependsOn
, making it snake case, so if you apply one, the other suggestions need to be applied. Good work so far!
Co-authored-by: Milo <50248166+Milo123459@users.noreply.github.com>
Co-authored-by: Milo <50248166+Milo123459@users.noreply.github.com>
Co-authored-by: Milo <50248166+Milo123459@users.noreply.github.com>
This also affects the NX provider.
Could you fix conflicts please? |
new version 1.5.1 and 1.5.0 -> https://turborepo.org/docs/handbook/deploying-with-docker#the-solution prune support |
@aleksrutins any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Just a few comments/questions. I am mainly concerned with breaking existing Turbo apps that are being built with Nixpacks currently. In all cases that we can't find a Turbo specific command, we should fallback to the default Node provider behaviour (for the most part this PR does that, just had a few questions in some places).
Co-authored-by: Jake Runzer <jakerunzer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks again for adding this 😄
Any docs for this? |
|
It seems like this is not working for pnpm (at least for me). After looking a bit into the code and the output of nixpacks it would seem like it prioritizes pnpm over turbo and outputs pnpm command for build instead of turbo command, and hence, it doesn't find the "start" command of the target app in my monorepo EDIT: Possbile fixes:
|
closes #456
This PR adds Turborepo support to Nixpacks.