Ruby on Rails: Do not run rake assets:precompile in build step if a Rails asset pipeline is not configured
#839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprockets is not installed
flybayer
approved these changes
Mar 24, 2023
coffee-cup
approved these changes
Mar 24, 2023
Added in 1e3bac2. The diff is a bit gruesome to review because of the example app. Here are the main changes: |
piperswe
suggested changes
Mar 24, 2023
src/providers/ruby.rs
Outdated
| fn uses_sprockets(&self, app: &App) -> Result<bool> { | ||
| if app.includes_file("Gemfile") { | ||
| let gemfile = app.read_file("Gemfile").unwrap_or_default(); | ||
| return Ok(gemfile.contains("sprockets")); |
piperswe
suggested changes
Mar 24, 2023
|
Hm, CI seems to be failing on an error unrelated to this changeset, which cancelled all existing running checks. The error is a https://github.com/railwayapp/nixpacks/actions/runs/4516055630/jobs/7954572560?pr=839#step:6:376 |
Yeah seems GitHub is having a few issues. Reran and will see |
half0wl
changed the title
rake assets:precompile in build step if sprockets is not installedrake assets:precompile in build step if a Rails asset pipeline is not configured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #751 by tweaking the Rails build plan to only include
bundle exec rake assets:precompileif sprockets is installed.Context
In Rails applications,
bundle exec rake assets:precompileis only included when the sprockets (Rails' asset pipeline) gem is installed. If sprockets is not a dependency (a common setup for Rails API-only apps [0] because they have no assets), the nixpacks build will fail becauserake assets:precompileis missing.[0] https://guides.rubyonrails.org/api_app.html
Checklist
(WIP -- I'd like to include a snapshot plan test in this PR. Gonna research how to do it.)added in 1e3bac2