Fix: correct node version parse #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miloas
changed the title
Miloas
force-pushed
the
fix/node-version-parse
branch
4 times, most recently
from
464302f to
2871cd2
Compare
Miloas
changed the title
Miloas
force-pushed
the
fix/node-version-parse
branch
from
2871cd2 to
7aefcb7
Compare
|
@half0wl please would you take a look this pr? |
|
BTW, I found every languages may have their own semver rules (for example, rust semver is different of node semver, most of languages use standard semver), so I cant port it to other languages. But I think other provider may have same issue. |
coffee-cup
reviewed
May 12, 2023
Miloas
force-pushed
the
fix/node-version-parse
branch
from
0207c5b to
82f2b06
Compare
Miloas
force-pushed
the
fix/node-version-parse
branch
from
82f2b06 to
2c022f2
Compare
|
Rust clippy: "you looks not smart" 😢 |
coffee-cup
reviewed
May 12, 2023
half0wl
approved these changes
May 15, 2023
There was a problem hiding this comment.
🥳
BTW, I found every languages may have their own semver rules (for example, rust semver is different of node semver, most of languages use standard semver), so I cant port it to other languages. But I think other provider may have same issue.
Yeah, good call pulling in node-semver to deal with this! Happy to see the regex gone ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
fix #858
#858 describe our current implementation cant parse
^14.10.3correctly, it will return the default node version, but it should return14.In real world
node-semveris more complicated. You can check how npm handle this https://github.com/npm/node-semverFortunately, we have a great crate can do same thing https://github.com/felipesere/node-semver-rs
How I think the original implementation?
inputs (one of):
v)outputs:
node version that statisfied the inputs version (one of):