fix: hexidecimal number for eth_feehistory blockcount

[alexandre-abrioux]

Hi!

First of all, thank you for creating this tool!
Its really great and has been working like a charm in projects that I've included it in.

However I had an issue running it against Quicknode's RPC servers.
You can test it with this simple demo.ts:

import { JsonRpcProvider } from '@ethersproject/providers';
import { suggestFees } from './src';

const main = async () => {
  try {
    const provider = new JsonRpcProvider("QUICKNODE_URL");
    const fee = await suggestFees(provider);
    // eslint-disable-next-line no-console
    console.log(fee);
  } catch (e) {
    // eslint-disable-next-line no-console
    console.error(e);
  }
};
main();

You will get this server error:

{"jsonrpc":"2.0","error":{"code":-32602,"message":"Invalid params: invalid type: integer `100`, expected a 0x-prefixed hex string with length between (0; 64]."},"id":42}

It looks like Infura and Alchemy both allow the use of an integer for the blockCount argument of eth_feeHistory.
But the doc actually specifies that it should be an hexadecimal number:
https://infura.io/docs/ethereum#operation/eth_feeHistory

This change fixes it by using ethers' hexadecimal utils.

[alexandre-abrioux]

PS: Here is the link of the official spec, described in the ethereum/execution-apis repository. You will find that blockCount should satisfy this regex: ^0x([1-9a-f]+[0-9a-f]*|0)$.

[alexandre-abrioux]

Hi @estebanmino! Any change of this being merged? It would be greatly appreciated! Thanks 🙂

[alexandre-abrioux]

Updates

1/ I released a branch in my fork that contains the (fixed) compiled JS files and that you can directly use in your packages.json:

"eip1559-fee-suggestions-ethers": "git+https://github.com/alexandre-abrioux/fee-suggestions#hex-feehistory-dist"

2/ Quicknode now supports integers for the blockCount argument of eth_feeHistory, so this specific provider is not impacted by the issue anymore. However, it would be great if this could still be merged, as the current code does not work with RPCs that strictly follow the specs (hexadecimals only).

[alexandre-abrioux]

Thank you very much @welps for the review and the merge! Do you think it could be released as a minor version for the npm package?

[welps]

Thank you very much @welps for the review and the merge! Do you think it could be released as a minor version for the npm package?

@alexandre-abrioux Yes, I don't have access to do this so I'm gonna be looking to get someone to do it this week

[alexandre-abrioux]

Thank you @welps 🙂

[welps]

@alexandre-abrioux Likely will release next week, I understand why #23 is happening and am trying to figure out a good solution so I can fit in a fix.

[alexandre-abrioux]

Great! Thanks again

[welps]

@alexandre-abrioux This has been released under 2.1.0 on npm

In regard to #23, see #23 (comment)