Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: frontierWallet support #1041

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Conversation

frontierpawan
Copy link
Contributor

@frontierpawan frontierpawan requested a review from a team as a code owner February 21, 2023 12:01
@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rainbowkit-example ❌ Failed (Inspect) Jun 28, 2023 3:45am
rainbowkit-site ❌ Failed (Inspect) Jun 28, 2023 3:45am

@vercel
Copy link

vercel bot commented Feb 21, 2023

@frontierpawan is attempting to deploy a commit to the rainbowdotme Team on Vercel.

A member of the Team first needs to authorize it.

@DanielSinclair
Copy link
Collaborator

Hey @frontierpawan. Please QA with the rainbowkit-example Vercel deployment here. Many teams have bumped into different behavior between localhost and a production environment.

@DanielSinclair
Copy link
Collaborator

Bumped into an issue where I am unable to connect the wallet after the initial "Deny" reply upon connect prompt. This may be an issue with the wallet's injector; injection is still required for proper detection in RainbowKit.
Screenshot 2023-02-23 at 1 57 01 AM

@punithbm
Copy link

punithbm commented Mar 1, 2023

Hi @DanielSinclair, thanks for highlighting. Can you please try now. I have attached the screen recording for the reference. Also note we are using manifest version 3 and have observed some issues with new chrome caching behaviour. But I think it should not change anything w.r.t rainbowkit implementation. Please check and let me know.

rainbowkit_issue.mov

@punithbm
Copy link

punithbm commented Mar 3, 2023

Hi @DanielSinclair , did you get any chance to look into the above comment ?

@punithbm
Copy link

punithbm commented Mar 7, 2023

@DanielSinclair Please check this☝️ whenever possible

@DanielSinclair
Copy link
Collaborator

@punithbm Seeing a CI error. Please run pnpm run lint:fix

@DanielSinclair
Copy link
Collaborator

@punithbm Can't seem to get detection working
Screenshot 2023-03-09 at 9 14 16 PM

@DanielSinclair
Copy link
Collaborator

Ran CI tests and a deployment to test against.

@DanielSinclair
Copy link
Collaborator

@frontierpawan @punithbm CI tests are failing

@DanielSinclair
Copy link
Collaborator

Please reference the discussion here regarding slow injector issues. This is an issue with the wallet injector, and we are holding off an adopting any API changes in RainbowKit for the time being. XDEFI was able to resolve their issue. #1042 (comment)

@punithbm
Copy link

punithbm commented May 19, 2023

@DanielSinclair We were able to find a workaround to address the injection detection issue in the Rainbow kit. We have submitted the Chrome build for review, and it might take 3-5 days to go live. Once it is live, we will notify you, and you can proceed with retesting it. Thank you for your continued support and the detailed information provided so far.

@punithbm
Copy link

Hi @DanielSinclair Our extension update is live. Can you please test in the latest version of the frontier wallet. Version 1.0.20 is working fine with Rainbowkit. Please check and let us know

@punithbm
Copy link

Hi @DanielSinclair any update on this ?

@punithbm
Copy link

Hi @DanielSinclair Please check and let us know on this PR ?

cc: @nickbytes

@punithbm
Copy link

@DanielSinclair any update on when this can be merged ? Please let us know

@punithbm
Copy link

punithbm commented Jul 7, 2023

@DanielSinclair any update on when this can be merged ? Please let us know

@rainbow-me rainbow-me locked as spam and limited conversation to collaborators Jul 7, 2023
@DanielSinclair DanielSinclair merged commit 66e8423 into rainbow-me:main Jul 13, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working connector New wallet connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants