fix: shim disconnect #1879
Closed
fix: shim disconnect #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Linked issue |
|
I believe this was fixed in a recent version of Wagmi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
shimDisconnectflag during connector preparation to prevent automatic reconnects of disconnected connectorsKnown issue
wagmi.WALLET_ID.disconnectedflags in localstorage. Onreconnectuponhydrate, Wagmi seems to move to the next EIP-6963 connector and fireconnect. After a series of connects and reconnects, there will be multiple different disconnect flags in localstorage for various wallets (even though we connected with the same wallet). This behavior results inshimDisconnectfunctionality not working as expectedhttps://github.com/wevm/wagmi/blob/97237bb05c30860b9b12c094e82a38ce59d9bedf/packages/core/src/hydrate.ts#L33
https://github.com/wevm/wagmi/blob/c403563be5dd3ab36d8582e69071ce87294468c2/packages/core/src/actions/reconnect.ts#L20