Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: coinbase wallet redirect behavior #1953

Merged
merged 5 commits into from
May 6, 2024
Merged

fix: coinbase wallet redirect behavior #1953

merged 5 commits into from
May 6, 2024

Conversation

DanielSinclair
Copy link
Collaborator

@DanielSinclair DanielSinclair commented Apr 30, 2024 •
edited
Loading

Changes

  • Mitigated behavior in Coinbase Wallet where the user would be captured in the in-app browser upon redirect.
  • Improved QR Code error correction reliability to assist wallets that sometimes fail to scan a RainbowKit QR Code.

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rainbowkit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 10:38pm
rainbowkit-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 10:38pm

@DanielSinclair DanielSinclair marked this pull request as ready for review May 6, 2024 18:57
@DanielSinclair DanielSinclair requested a review from a team as a code owner May 6, 2024 18:57
magiziz
magiziz approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@magiziz magiziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great

@DanielSinclair DanielSinclair merged commit f0b3b25 into main May 6, 2024
6 of 8 checks passed
@DanielSinclair DanielSinclair deleted the @daniel/enableMobileWalletLink branch May 6, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magiziz magiziz magiziz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielSinclair @magiziz