feat(CoinbaseWalletOptions): add preference #2002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wilsoncusack is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks @wilsoncusack. Looking into this now 👍 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@wilsoncusack Changes looks great. I have a quick question. When setting
Works great with |
|
@wilsoncusack Gotcha. Alright we'll have a last round of review and cut a release early next week. Thanks for getting this done👍 |
|
@wilsoncusack Closing this in favor of #2017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Coinbase Wallet Wagmi connector now has a
preferenceargument, with type'all' | 'smartWalletOnly' | 'eoaOnly' | undefined.Being able to pass this preference allows app developers better configurability of the Coinbase Wallet popup. Preference based behavior documented here.
Additionally, ahead of Smart Wallet mainnets launch––as of Coinbase Wallet SDK version
4.0.2(used in Wagmi ^2.9.5)––the Smart Wallet option will no longer show in the Coinbase Wallet popup when the sending app is onlocalhost. Developers found the host based behavior confusing. Now, if developers using versions^4.0.0want to see the Smart Wallet in the popup ahead of mainnets launch, they need to passsmartWalletOnly.