Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigator object is empty #2039

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

0xAskar
Copy link
Contributor

@0xAskar 0xAskar commented Jun 9, 2024

Navigator object is empty in some cases and as a result throws an error in getBrowser preventing the user from using the app in dev mode. This checks if is an empty object and then returns Browser.browser, simple fix. reference to #2036 (comment)

@0xAskar 0xAskar requested a review from a team as a code owner June 9, 2024 03:05
Copy link

vercel bot commented Jun 9, 2024

@0xAskar is attempting to deploy a commit to the rainbowdotme Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rainbowkit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 7:06am
rainbowkit-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 7:06am

Copy link
Contributor Author

@0xAskar 0xAskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why you not keep the if statement and keep the optional chaining as well?

@DanielSinclair DanielSinclair merged commit 001a0a9 into rainbow-me:main Jun 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants