fix: resolve issue where Kaikas wallet does not prompt user to connect upon icon click #2093
Conversation
…t upon icon click
|
@0oooooooo0 is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| : getInjectedConnector({ | ||
| namespace: 'klaytn', | ||
| }), | ||
| : getInjectedConnector(isMobile() ? { target: typeof window !== 'undefined' ? window.klaytn : undefined } : { namespace: 'klaytn' }), |
There was a problem hiding this comment.
The prior configuration would have the same affect here
| @@ -36,7 +37,7 @@ export const kaikasWallet = ({ | |||
| android: 'https://play.google.com/store/apps/details?id=io.klutch.wallet', | |||
| mobile: 'https://app.kaikas.io', | |||
| }, | |||
| mobile: { getUri: shouldUseWalletConnect ? getUri : undefined }, | |||
| mobile: { getUri: shouldUseWalletConnect ? getUri : (uri: string) => `kaikas://wc?uri=${encodeURIComponent(uri)}` }, | |||
There was a problem hiding this comment.
Unnecessary duplication
| const getUri = (uri: string) => { | ||
| return `kaikas://walletconnect?uri=${encodeURIComponent(uri)}`; | ||
| const getUri = () => { | ||
| return `kaikas://wallet/browser?url=${encodeURI(window.location.origin)}` |
There was a problem hiding this comment.
This would actually be for the WalletConnect flow not EIP-1193, and we wouldn't want to push users to the in-app browser on desktop. Did Kaikas stop supporting the kaikas://walletconnect deep link?
There was a problem hiding this comment.
@DanielSinclair Currently kaikas do not seem to be being managed. kaikas is a wallet mainly used on the Klaytn mainnet, and it was said that the Klaytn mainnet and finschia mainnet will be integrated in the third quarter of this year. I may update it again at that time, but currently it is not well supported, so it would be best if it works in the browser.
https://medium.com/lineblockchain/en-say-hello-to-kaia-1b1d489a8b8f
Currently, clicking on the Kaikas app on mobile takes users to the Kaikas app but does not prompt them to link their wallet.
This seems to be because the Kaikas app does not support EIP-1193.
So I made it work by making the service available in the browser inside the Kaikas app
Now Kaikas is working properly on mobile 😄