Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring a name for the archived binary #1

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Allow configuring a name for the archived binary #1

merged 1 commit into from
Jul 29, 2021

Conversation

magni-
Copy link

@magni- magni- commented Jul 28, 2021

Same PR as rhysd#43, but for our fork

This will default to the existing behavior: using the name of the currently running executable.

Fixes rhysd#42
@magni-
Copy link
Author

magni- commented Jul 28, 2021

/reviewme @rainforestapp/devs

@marvin-rfbot marvin-rfbot bot added the review label Jul 28, 2021
Copy link

@jbarber jbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@magni- magni- merged commit 905f4fc into master Jul 29, 2021
@marvin-rfbot marvin-rfbot bot deleted the pp/42 branch July 29, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants