This repository has been archived by the owner on Nov 29, 2024. It is now read-only.
update tranche charting #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedavidmeister
suggested changes
Jun 18, 2024
src/tranche/tranche-space.rain
Outdated
| @@ -317,11 +317,11 @@ charts: | |||
| - label: Starting tranche | |||
| value: 0.2.0 | |||
| description: 'This strategy starts executing sells at the initial tranche (stack item 0.2.0)' | |||
| - label: Initial sell price | |||
| value: 0.5.3 | |||
| - label: Initial effective sell price | |||
There was a problem hiding this comment.
this is the final literal io ratio, it's not a derived price
There was a problem hiding this comment.
yes correct, for sell order final io ratio is the effective sell price. Do you mean to say I remove the word 'effective' ?
|
|
thedavidmeister
approved these changes
Jul 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Incorrect stack index value for charting variable
Solution
Checks
By submitting this for review, I'm confirming I've done the following: