Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fixes on some pages and information on Disabled/Paused on plugins #60

Merged
merged 13 commits into from
Nov 4, 2024

Conversation

Drgabi18
Copy link
Contributor

@Drgabi18 Drgabi18 commented Nov 4, 2024

Hello! I hope the commit titles are descriptive enough for what I commited :P

I made a few fixes related to mistakes I did in my last pull request and also added some new stuff.

I also added some info related to how Disabled/Paused work, as I asked (and got info) on the forums. I went with

What do the Disabled and Paused options do in a plugin?

If either are set to 1, they only affects the execution of the Update function. Rainmeter will still call the Initialize, Reload and Finalize functions.
Ideally, plugins should do the bulk of the "work" in the Update function to minimize any processing and to take advantage of what the user expects when the options (and bangs for set options) are used.
Avoid relying on the Update function to control threads if multi-threading.

on the Guidelines page and

This is the only function affected by the Disabled and Paused options.

on the Anatomy page, which I hope signals enough that only Update gets stopped by those options.

If one of the commits isn't consistent (like 317b051 because it dosen't touch LPCWSTR on C++) you can not add them, it's okay.

@jsmorley jsmorley merged commit 49b3d23 into rainmeter:master Nov 4, 2024
@jsmorley
Copy link
Member

jsmorley commented Nov 4, 2024

Changes merged... Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants