Add some logic check when overwrite a saved object (opensearch-projec…

…t#32) * feat: add some logic check when overwrite a saved object Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type check Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
raintygao · Aug 3, 2023 · 274c96d · 274c96d
1 parent 29fccee
commit 274c96d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/core/server/saved_objects/service/lib/repository.ts b/src/core/server/saved_objects/service/lib/repository.ts
@@ -280,6 +280,18 @@ export class SavedObjectsRepository {
       }
     }
 
+    let savedObjectWorkspaces;
+
+    if (id && overwrite) {
+      // do not overwrite workspaces
+      const currentItem = await this.get(type, id);
+      if (currentItem && currentItem.workspaces) {
+        savedObjectWorkspaces = currentItem.workspaces;
+      }
+    } else {
+      savedObjectWorkspaces = workspaces;
+    }
+
     const migrated = this._migrator.migrateDocument({
       id,
       type,
@@ -290,7 +302,7 @@ export class SavedObjectsRepository {
       migrationVersion,
       updated_at: time,
       ...(Array.isArray(references) && { references }),
-      ...(Array.isArray(workspaces) && { workspaces }),
+      ...(Array.isArray(savedObjectWorkspaces) && { workspaces: savedObjectWorkspaces }),
     });
 
     const raw = this._serializer.savedObjectToRaw(migrated as SavedObjectSanitizedDoc);

diff --git a/src/core/types/saved_objects.ts b/src/core/types/saved_objects.ts
@@ -113,6 +113,7 @@ export interface SavedObject<T = unknown> {
    * space.
    */
   originId?: string;
+  workspaces?: string[];
 }
 
 export interface SavedObjectError {