chore: update name and assertion

Signed-off-by: tygao <tygao@amazon.com>
raintygao · Sep 25, 2023 · 6050914 · 6050914
1 parent c9f5142
commit 6050914
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts b/src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
@@ -251,12 +251,12 @@ export class WorkspaceSavedObjectsClientWrapper {
       objects: Array<SavedObjectsBulkCreateObject<T>>,
       options: SavedObjectsCreateOptions = {}
     ): Promise<SavedObjectsBulkResponse<T>> => {
-      const isPassedWorkspaces = options?.workspaces && options.workspaces.length > 0;
+      const hasTargetWorkspaces = options?.workspaces && options.workspaces.length > 0;
 
       if (
-        isPassedWorkspaces &&
+        hasTargetWorkspaces &&
         !(await this.validateMultiWorkspacesPermissions(
-          options.workspaces!,
+          options.workspaces ?? [],
           wrapperOptions.request,
           [WorkspacePermissionMode.LibraryWrite, WorkspacePermissionMode.Management]
         ))
@@ -272,7 +272,7 @@ export class WorkspaceSavedObjectsClientWrapper {
             !(await this.validateWorkspacesAndSavedObjectsPermissions(
               await wrapperOptions.client.get(type, id),
               wrapperOptions.request,
-              !isPassedWorkspaces
+              !hasTargetWorkspaces
                 ? // If no workspaces are passed, we need to check the workspace permission of object when overwrite.
                   [WorkspacePermissionMode.LibraryWrite, WorkspacePermissionMode.Management]
                 : [],
@@ -293,12 +293,12 @@ export class WorkspaceSavedObjectsClientWrapper {
       attributes: T,
       options?: SavedObjectsCreateOptions
     ) => {
-      const isPassedWorkspaces = options?.workspaces && options.workspaces.length > 0;
+      const hasTargetWorkspaces = options?.workspaces && options.workspaces.length > 0;
 
       if (
-        isPassedWorkspaces &&
+        hasTargetWorkspaces &&
         !(await this.validateMultiWorkspacesPermissions(
-          options.workspaces!,
+          options.workspaces ?? [],
           wrapperOptions.request,
           [WorkspacePermissionMode.LibraryWrite, WorkspacePermissionMode.Management]
         ))
@@ -312,7 +312,7 @@ export class WorkspaceSavedObjectsClientWrapper {
         !(await this.validateWorkspacesAndSavedObjectsPermissions(
           await wrapperOptions.client.get(type, options.id),
           wrapperOptions.request,
-          !isPassedWorkspaces
+          !hasTargetWorkspaces
             ? // If no workspaces are passed, we need to check the workspace permission of object when overwrite.
               [WorkspacePermissionMode.LibraryWrite, WorkspacePermissionMode.Management]
             : [],