Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow sending generic API requests #352

Closed
wants to merge 1 commit into from

Conversation

MaximBalaganskiy
Copy link

This will allow for calling APIs which are missing in the current implementation

This will allow for calling APIs which are missing in the current implementation
@Zetanova
Copy link

Zetanova commented Jul 3, 2024

would resolve #342

@rajanadar
Copy link
Owner

this is a fantastic intent @MaximBalaganskiy . I 100% understand what this is meant to do.

However, the sole purpose of VaultSharp is to be that strong first-class C# layer to hide all http/api things.

It is also the motivation for users to raise missing api features and for us to add it as strongly typed methods.

Doing this will open up the http world to callers, who will then have this weird hybrid code in production and management rarely gives time to unwind those things.

I am going to close this PR solely due to the core tenet of the library. Not to expose polymath/http at all.
Your intent is 100% appreciated.

@rajanadar rajanadar closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants