Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#353 Optimise dependency management #354

Closed
wants to merge 1 commit into from
Closed

#353 Optimise dependency management #354

wants to merge 1 commit into from

Conversation

thompson-tomo
Copy link

closes #353

@rajanadar
Copy link
Owner

thanks @thompson-tomo

There are 2 problems being solved in this PR. Removal of STJ dependency and grouping all or conditions.
Can you please modify the PR to just solve STJ? Leave the grouping expanded. It is deliberate for readability and later deprecation when a version goes out of support.

rajanadar
rajanadar requested changes Sep 8, 2024
View reviewed changes
Copy link
Owner

@rajanadar rajanadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@rajanadar rajanadar closed this Sep 8, 2024
@thompson-tomo thompson-tomo deleted the chore/#353_DependencyGraphOptimisation branch September 8, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajanadar rajanadar rajanadar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce inclusion of STJ
2 participants
@thompson-tomo @rajanadar