Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect changes in Testgrid config post s3 migration and prow.tanzu.io migration #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rajaskakodkar
Copy link
Owner

This is a follow-up on migration of prow logs to S3.

Front end of testgrid could be generated with the changes in this PR.

However, testgrid backend has updater controller which checks for Prow job logs and populates cells in testgrid. This controller currently accepts only GCS buckets for source of truth of Prow job logs and does not work with S3.

{"config":"gs://vagator-testgrid/config","error":"read first column: group path: gs://bucket may not contain a port: gs://s3:/tanzu-prow-logs/logs/post-test-image/","file":"pkg/updater/updater.go:378","func":"github.com/GoogleCloudPlatform/testgrid/pkg/updater.Update.func
2","group":"post-test-image","level":"error","msg":"Failed to update group","time":"2022-03-31T09:17:04Z"}

This PR should be merged only when updater supports S3.

Signed-off-by: Rajas Kakodkar rkakodkar@vmware.com

Signed-off-by: Rajas Kakodkar <rkakodkar@vmware.com>
@prowtce
Copy link
Contributor

prowtce bot commented Mar 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rajaskakodkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rajaskakodkar
Copy link
Owner Author

/hold

@rajaskakodkar
Copy link
Owner Author

/title Reflect changes in Testgrid config post s3 migration and prow.tanzu.io migration

@rajaskakodkar
Copy link
Owner Author

/retitle Reflect changes in Testgrid config post s3 migration and prow.tanzu.io migration

@prowtce prowtce bot changed the title Reflect changes post s3 migration and prow.tanzu.io migration Reflect changes in Testgrid config post s3 migration and prow.tanzu.io migration Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant