Added Amazon ECR Credential Helper #61
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yashsingh74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Please check and review. Q. Is it ok to add the AWS Account ID publicly open in the run.sh? |
images/image-builder/run.sh
Outdated
| @@ -5,6 +5,19 @@ export registry_path="${2}" | |||
|
|
|||
| source /usr/local/bin/dind.sh | |||
|
|
|||
| # Configuring docker-credential-helper-ecr | |||
There was a problem hiding this comment.
Can you please add this inside the if [[ "${REGISTRY_ENABLED}" == "true" ]]; then block?
images/image-builder/run.sh
Outdated
| { | ||
| "credHelpers": { | ||
| "public.ecr.aws": "ecr-login", | ||
| "<aws_account_id>.dkr.ecr.<region>.amazonaws.com":"ecr-login" |
There was a problem hiding this comment.
I wonder if this is required based on https://github.com/awslabs/amazon-ecr-credential-helper#docker
There was a problem hiding this comment.
I removed the credHelpers. It is not needed for pull and push for docker images.
I think it should be ok, however, I wonder if we will require it for public ECR. |
|
Lets merge this post infra migration. /hold |
|
https://github.com/awslabs/amazon-ecr-credential-helper#troubleshooting mentions that logs can be captured in |
This PR aims to add the amazon ECR credential helper.