Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: update external secrets from the shared ES account secret-manager #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Priyankasaggu11929
Copy link
Collaborator

No description provided.

@prowtce
Copy link
Contributor

prowtce bot commented Apr 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Priyankasaggu11929
Copy link
Collaborator Author

@rajaskakodkar Need help understanding how to test this updated External Secrets file?

If I apply the manifest in the current Prow PoC cluster, it would check for the secrets in the ES account secret-manager? Or I need to follow some more steps to point the current cluster to the new secret-manager?

@rajaskakodkar
Copy link
Owner

@Priyankasaggu11929 In this PR you have touched external-secrets.yaml and kubernetes-external-secrets-sa.yaml. One way to test this is apply all the untouched kubernetes-external-secrets*.yaml from https://github.com/rajaskakodkar/tanzu-test-infra/tree/main/config/prow + the files you have touched in this PR. All the secrets mentioned in external-secrets.yaml should be created in the cluster where you apply these files.

@Priyankasaggu11929 Priyankasaggu11929 changed the title update external secrets from the shared ES account secret-manager WIP: update external secrets from the shared ES account secret-manager Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants