Cache scanner files if WAYLAND_SCANNER_USE_CACHE is 1 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthiasKunnen
force-pushed
the
cache-files
branch
from
9d2b4a9 to
d37dd38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am again :)
I felt bad about hammering freedesktop's GitLab repo every time I tested generating the whole repo so I added this cache layer. It's a win-win for both freedesktop and the developer, we both get less data usage and we get faster generate time.
The system works by hashing the URL and saving it to
$XDG_CACHE_DIR/go-wayland/scanner/$pkgName-$hash. Since tags are used, this cache should never go stale.To test this PR, PR #8 is required.
Any and all feedback welcome.