Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GoogleTest w/ Catch2 #251

Closed
rakhimov opened this issue Jan 4, 2018 · 0 comments
Closed

Replace GoogleTest w/ Catch2 #251

rakhimov opened this issue Jan 4, 2018 · 0 comments
Labels
testing
Milestone
v0.16.2

Comments

@rakhimov
Copy link
Owner

rakhimov commented Jan 4, 2018

Catch2 is a testing framework for modern C++ (Issue #250).

SCRAM depends on a custom patch to GoogleTest,
so sooner or later it must be dealt with.
@rakhimov rakhimov added this to the v0.16.2 milestone Jan 4, 2018
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Add catch2 as a git submodule
d648e24 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Configure Catch2 tests build in CMakeLists
ba5093a 
This is a transitional configuration
with catch2 tests being run by scram_catch binary.

Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Run catch2 tests in CI
a9ffccc 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in linear_map_tests.cc
cce1d13 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Exclude test cc files from cpplint on Travis
2edef8e 
cpplint is getting confused with Catch2 macros.

Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in performance_tests.cc
b819252 
This uses Catch2 fixtures to replace GTest fixtures.
The major annoying difference
is that Catch2 does not namespace test names with fixture names,
so the test names must be unique globally.

Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in xml_stream_tests.cc
88d6ff8 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in settings_tests.cc
dae29b0 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in config_tests.cc
7eee04b 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in element_tests.cc
db9c66d 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in event_tests.cc
0053789 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in expression_tests.cc
bbc672e 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in extern_function_tests.cc
9b3bc3f 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in ccf_group_tests.cc
65af05c 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in fault_tree_tests.cc
7c5b71d 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in alignment_tests.cc
f57cff9 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in pdag_tests.cc
6e7934e 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in serialization_tests.cc
a7d85b8 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in initializer_tests.cc
e241db7 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in docs, CMake, CI scripts
92e85a3 
The transition of all tests is not complete.
Catch2 does not support value parametrized tests.
It still needs a workaround.

Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Remove GoogleTest git submodule
6d73910 
Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Adjust Catch2 exit code for Valgrind
29336e0 
Catch2 abuses exit codes to mean various things.

Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in risk_analysis_tests
b79c3b4 
Parametrized tests are not yet implemented.

Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Replace GTest w/ Catch2 in bench_*_tests.cc
4dda95b 
To ease the burden, transitional macros are provided
to convert GTest macros into Catch2 macros.

This completes the transition of test source files to Catch2.
However, parametrized tests are not yet implemented.

Issue #251
rakhimov added a commit that referenced this issue Jan 12, 2018
@rakhimov
Workaround parametrized tests w/ Catch2
faa4f2b 
Catch2 does not support parametrized tests.
This is a workaround with a static data.
It is not ideal, but runs the needed algorithms.

Issue #251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
v0.16.2
Development

No branches or pull requests
1 participant
@rakhimov