Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define colors for the integrated terminal #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rvighne
Copy link

@rvighne rvighne commented Feb 27, 2021

This sets the 16 default colors within the Vim 8 integrated terminal (via g:terminal_ansi_colors) so that terminal apps look as expected. The colors are in terms of the already-defined variables, so it should stay consistent and work in light mode too.

Here's a comparison with One Half Dark from Windows Terminal. Note that WT decided to use a very bright color for white, but I've chosen to stick with the colorscheme so it looks better next to actual editor buffers.

Comparison with Windows Terminal's "One Half Dark"

This sets g:terminal_ansi_colors using the already-defined variables.
It makes terminal apps look normal, by setting the 16 default colors.
See the Vim help for term_setansicolors()
@lygamac
Copy link

lygamac commented Mar 24, 2021

Terminal color was removed on #104 because the colors were inconsistent when using a light theme.

I second to re-add the colors, provided that we add support to the light theme too.

@rvighne
Copy link
Author

rvighne commented Mar 26, 2021

These colors use the variables defined by the theme, like syntax_bg/syntax_fg. Since those are set conditionally based on the light/dark mode, I believe it works fine in that case. Here is a screenshot:

Screenshot of Vim terminal colors in light mode

Other terminal apps also look OK (actually I'm not at all a fan but actual light mode users can judge whether this looks correct 😁):

image

@lygamac lygamac mentioned this pull request Mar 26, 2021
@rvighne
Copy link
Author

rvighne commented Jun 4, 2022

Due to inactivity from the maintainers, I've merged this (and some other long-standing PR's) into my fork: rvighne#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants