Merzlya display #474
Merzlya display #474
Conversation
|
The "L" keybind is crashing with: |
|
If "L" doesn't work, it should be a pretty easy pull request to create. I'm starting to think the way to get back into coding on rtorrent and libtorrent is to not touch those things as that forces people to do things to fix their favorite pet peeve. |
|
It's not a pet peeve, i was just reporting the error. |
|
No, what I'm saying is that it's easy to create a pull request fixing that minor issue. Which is something people who are affected by an issue that is easy to fix should really do as a favor to the people (or person in this case) that need to manage a project... in this case, a project far too big for just one individual. Basically fixing the command tied to the L key should be so easy that I should have a pull request waiting for me, not a ticket telling me I need to fix some code. If you think this way of approaching the project is a bit dickish then you should see my inbox. I'm trying to get more people to not just create issues for small and easily fixed issues, but to actually make them give me an easy merge request that I can just click a couple of buttons and get done with. Put in some effort and it will be part of rtorrent/libtorrent. Don't, and it's probably going to be ignored. When it came to this particular pull request I'd already spent about an hour or so refactoring the code. It isn't my intention to be 'in a bad mood', it is rather that having put in the kind of effort that I've done, I'm not really that forgiving of people who should know how to fix a minor detail not put in the small amount of work needed to create something I can easily merge. One road leads to burnout, the other to a more active community. If I need to sound peeved to make the latter happen then so be it. |
|
I understand what you're saying. |
|
I understand what you mean and that should be the power of an opensource project, especially with help of GitHub, but I don't think this rushing world works like this, especially nowdays. :( And broken/untested code should never get into master branch :) (I don't want you be pissed off, more than that, cheer you up! Thanks) |
|
The thing is that the above issue is just a string replace in one part of the code that should be easy to fix. If I have to do everything then I'm more likely to do nothing. And unless there's CI for every part of rtorrent I'm relying on the users to point out / fix issues. More of the latter is better, as I'm less likely to continue working on this if I have to fix all of the former. |
|
Related to that, people who cannot code C++ can still help with docs (especially the wiki). By doing so, you free up time of people who CAN write C++, thus helping yourself also (by getting new features). If the current activity level continues, or even increases, we could end up with new, documented features. 😼 |
|
Well, in this case you don't even need to know C++ nor C, the issue is just a string that needs replacing. As long as you know how GitHub works the task is not that different from doing documentation. For those who might question why I haven't done it, while instead writing this much in tickets, it is because I don't want to have to deal with all the minor issues that will appear in the future. |
|
I've tried changing "download.list.layout" to "ui.torrent_list.layout" in |
|
It's supposed to be "ui.torrent_list.layout.set". |
|
Yes. |
|
Ahh... you need to look at the changes I made to the code... It's "full" and "compact", not 0 and 1. |
|
Use the "branch" command to make it work as you expect, or just add a C++ method that switches between modes. |
|
note to self I really need to learn C... |
|
BTW, why is this called "torrent_list" when really everywhere else it is called "download_list"? This should be fixed before a release, since it's yet-another-dreaded-rename-of-commands waiting to happen. |
Cleaned up merzlya's compact torrent display patch.