Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Task Type Support #50

Merged
merged 5 commits into from
Jan 7, 2024
Merged

Add Custom Task Type Support #50

merged 5 commits into from
Jan 7, 2024

Conversation

mjburtenshaw
Copy link
Contributor

@mjburtenshaw mjburtenshaw commented Jan 4, 2024

Problem

As a developer, I want to create Tasks using custom task types.

Solution

📖 Definition: In ClickUp's nomenclature, a custom task type is a kind of custom item. In like fashion, I used custom item to name the data structures and custom task type as instances of custom items.

Main Quest

  • Add CustomItemId to TaskRequest in clickup/tasks.go.
  • Add CustomItemId to Task in clickup/tasks.go.
  • Document nuances in values as comments.

Side Quests

  • Add a CustomTaskTypes service to facilitate programmatic assignment of Task types.

Validation

  • I updated the Get Task test.
  • I added a test file for the CustomTaskTypes service.
  • I tested an implementation of my fork in a private project with success.

@mjburtenshaw
Copy link
Contributor Author

@w-haibara san, your review is appreciated.

+@a-thug (major contributor)
+@heldeen (has recent context)

Thank you, all!

@w-haibara w-haibara self-requested a review January 7, 2024 12:33
Copy link
Contributor

@w-haibara w-haibara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks!

@w-haibara w-haibara merged commit a255630 into raksul:main Jan 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants