Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment ID type and Time Tracking 2.0 #58

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

jonathanschmittcs
Copy link

@jonathanschmittcs jonathanschmittcs commented Jun 27, 2024

Changed the comment ID type from string to int.

Reason: an error was occurring during json marshall when adding a comment to a task.

Add Time Tacking feature with CreateTimeTracking and GetTimeTracking methos.

@w-haibara w-haibara self-requested a review June 28, 2024 01:47
@w-haibara
Copy link
Contributor

HI, @jonathanschmittcs. Thank you for your contribution.
Could you please confirm the failed CI job?

@jonathanschmittcs jonathanschmittcs changed the title Update comment ID type Update comment ID type and Time Tracking 2.0 Jun 28, 2024
@jonathanschmittcs
Copy link
Author

HI, @jonathanschmittcs. Thank you for your contribution. Could you please confirm the failed CI job?

Sure 😃 ! I also implemented some methods and tests for time tracking.

Thanks for creating go-clickup ❤️

…instead of TaskRequest. Fixed assignees update struct
Copy link
Contributor

@w-haibara w-haibara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I appreciate your contribution 🚀

@w-haibara w-haibara merged commit 599bb23 into raksul:main Jul 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants