Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icat5 endpoints #383

Merged
merged 8 commits into from
Nov 23, 2022
Merged

Add icat5 endpoints #383

merged 8 commits into from
Nov 23, 2022

Conversation

Reillyhewitson
Copy link
Contributor

This PR will close #373

Description

I have created models for ICAT5 entities as they were required to start the application, I have added the entities to the entity dictionary and added new entries to the postman collection so it is easy to try out the new enrpoints.

Testing Instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?
  • Ensure that Changes to tests so they pass with icat 5 #381 is merged first

Agile Board Tracking

Connect to #373

@Reillyhewitson Reillyhewitson linked an issue Oct 5, 2022 that may be closed by this pull request
2 tasks
@Reillyhewitson Reillyhewitson changed the title Feature/icat5 endpoints#373 Add icat5 endpoints Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 94.48% // Head: 94.83% // Increases project coverage by +0.35% 🎉

Coverage data is based on head (6f10cb3) compared to base (4d6b066).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/icat5-tests#374     #383      +/-   ##
===========================================================
+ Coverage                    94.48%   94.83%   +0.35%     
===========================================================
  Files                           39       39              
  Lines                         3116     3327     +211     
  Branches                       311      311              
===========================================================
+ Hits                          2944     3155     +211     
  Misses                         144      144              
  Partials                        28       28              
Impacted Files Coverage Δ
...api/src/resources/entities/entity_endpoint_dict.py 100.00% <ø> (ø)
...gateway_api/src/datagateway_api/database/models.py 97.27% <100.00%> (+0.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MRichards99 MRichards99 changed the base branch from main to feature/icat5-tests#374 October 19, 2022 09:20
datagateway_api/src/datagateway_api/database/models.py Outdated Show resolved Hide resolved
datagateway_api/src/datagateway_api/database/models.py Outdated Show resolved Hide resolved
datagateway_api/src/datagateway_api/database/models.py Outdated Show resolved Hide resolved
datagateway_api/src/datagateway_api/database/models.py Outdated Show resolved Hide resolved
datagateway_api/src/datagateway_api/database/models.py Outdated Show resolved Hide resolved
datagateway_api/src/datagateway_api/database/models.py Outdated Show resolved Hide resolved
@Reillyhewitson Reillyhewitson force-pushed the feature/icat5-endpoints#373 branch 3 times, most recently from 69039a1 to 2f50120 Compare October 26, 2022 15:56
@Reillyhewitson Reillyhewitson force-pushed the feature/icat5-endpoints#373 branch from ea11e80 to 63c2faa Compare November 1, 2022 11:19
Base automatically changed from feature/icat5-tests#374 to main November 10, 2022 15:04
@Reillyhewitson Reillyhewitson merged commit 3943ec4 into main Nov 23, 2022
@Reillyhewitson Reillyhewitson deleted the feature/icat5-endpoints#373 branch November 23, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Endpoints for ICAT 5
2 participants