-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icat5 endpoints #383
Add icat5 endpoints #383
Conversation
Codecov ReportBase: 94.48% // Head: 94.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/icat5-tests#374 #383 +/- ##
===========================================================
+ Coverage 94.48% 94.83% +0.35%
===========================================================
Files 39 39
Lines 3116 3327 +211
Branches 311 311
===========================================================
+ Hits 2944 3155 +211
Misses 144 144
Partials 28 28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
69039a1
to
2f50120
Compare
ea11e80
to
63c2faa
Compare
This PR will close #373
Description
I have created models for ICAT5 entities as they were required to start the application, I have added the entities to the entity dictionary and added new entries to the postman collection so it is easy to try out the new enrpoints.
Testing Instructions
Add a set up instructions describing how the reviewer should test the code
icatdb Generator Script Consistency Test
CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:
,feat:
orBREAKING CHANGE:
so a release is automatically made via GitHub Actions upon merge?Agile Board Tracking
Connect to #373