Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/db backend tests #370 #385

Merged
merged 23 commits into from
Nov 23, 2022
Merged

Conversation

Reillyhewitson
Copy link
Contributor

This PR will close #370

Description

Added tests to mirror the existing tests on the ICAT backend in order to improve coverage for the DB backend

Testing Instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?
  • {more steps here}

Agile Board Tracking

Connect to #370

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@22141b5). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage        ?   96.90%           
=======================================
  Files           ?       39           
  Lines           ?     3331           
  Branches        ?      313           
=======================================
  Hits            ?     3228           
  Misses          ?       76           
  Partials        ?       27           
Impacted Files Coverage Δ
...ateway_api/src/datagateway_api/database/helpers.py 95.78% <100.00%> (ø)
...gateway_api/src/datagateway_api/database/models.py 97.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Reillyhewitson Reillyhewitson force-pushed the tests/db-backend-tests-#370 branch from d0634b4 to 9419db4 Compare November 2, 2022 16:23
@Reillyhewitson Reillyhewitson force-pushed the tests/db-backend-tests-#370 branch from 5b32095 to 652d1db Compare November 3, 2022 11:37
@Reillyhewitson Reillyhewitson marked this pull request as ready for review November 16, 2022 09:11
@MRichards99 MRichards99 changed the base branch from main to feature/icat5-endpoints#373 November 21, 2022 17:16
@MRichards99 MRichards99 changed the base branch from feature/icat5-endpoints#373 to main November 21, 2022 17:17
Copy link
Collaborator

@MRichards99 MRichards99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An additional 2% is really good work. There's a few things that I've noticed but the bulk of it looks really good - I know tests isn't the most interesting work so thanks for getting on with it :)

MRichards99
MRichards99 previously approved these changes Nov 23, 2022
Copy link
Collaborator

@MRichards99 MRichards99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you just need to fix the merge conflict (looks like a simple one) and then you can merge!

@Reillyhewitson Reillyhewitson merged commit 41c1586 into main Nov 23, 2022
@Reillyhewitson Reillyhewitson deleted the tests/db-backend-tests-#370 branch November 23, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Code Coverage for Database Backend
2 participants