-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests/db backend tests #370 #385
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
=======================================
Coverage ? 96.90%
=======================================
Files ? 39
Lines ? 3331
Branches ? 313
=======================================
Hits ? 3228
Misses ? 76
Partials ? 27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
d0634b4
to
9419db4
Compare
5b32095
to
652d1db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An additional 2% is really good work. There's a few things that I've noticed but the bulk of it looks really good - I know tests isn't the most interesting work so thanks for getting on with it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, you just need to fix the merge conflict (looks like a simple one) and then you can merge!
This PR will close #370
Description
Added tests to mirror the existing tests on the ICAT backend in order to improve coverage for the DB backend
Testing Instructions
Add a set up instructions describing how the reviewer should test the code
icatdb Generator Script Consistency Test
CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:
,feat:
orBREAKING CHANGE:
so a release is automatically made via GitHub Actions upon merge?Agile Board Tracking
Connect to #370