-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/use yaml config#372 #388
Conversation
BREAKING CHANGE: Remove support for json configuration files
Codecov ReportBase: 94.48% // Head: 94.48% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 39 39
Lines 3118 3118
Branches 312 312
=======================================
Hits 2946 2946
Misses 144 144
Partials 28 28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of picky things that I've picked up on (sorry!).
This PR will close #372
Description
Enter a description of the changes here
Testing Instructions
Add a set up instructions describing how the reviewer should test the code
icatdb Generator Script Consistency Test
CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:
,feat:
orBREAKING CHANGE:
so a release is automatically made via GitHub Actions upon merge?Agile Board Tracking
Connect to #372