Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use yaml config#372 #388

Merged
merged 27 commits into from
Nov 22, 2022
Merged

Conversation

Reillyhewitson
Copy link
Contributor

@Reillyhewitson Reillyhewitson commented Nov 16, 2022

This PR will close #372

Description

Enter a description of the changes here

Testing Instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?
  • {more steps here}

Agile Board Tracking

Connect to #372

@Reillyhewitson Reillyhewitson linked an issue Nov 16, 2022 that may be closed by this pull request
7 tasks
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 94.48% // Head: 94.48% // No change to project coverage 👍

Coverage data is based on head (5a63e70) compared to base (57edaaa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          39       39           
  Lines        3118     3118           
  Branches      312      312           
=======================================
  Hits         2946     2946           
  Misses        144      144           
  Partials       28       28           
Impacted Files Coverage Δ
datagateway_api/src/datagateway_api/backends.py 100.00% <ø> (ø)
...ay_api/src/datagateway_api/query_filter_factory.py 100.00% <ø> (ø)
datagateway_api/src/common/config.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@MRichards99 MRichards99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of picky things that I've picked up on (sorry!).

noxfile.py Outdated Show resolved Hide resolved
.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Reillyhewitson Reillyhewitson merged commit 5060d5e into main Nov 22, 2022
@Reillyhewitson Reillyhewitson deleted the feature/use-yaml-config#372 branch November 22, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace JSON Config with YAML
2 participants