Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #402

Merged
merged 155 commits into from
Feb 21, 2023
Merged

Update Dockerfile #402

merged 155 commits into from
Feb 21, 2023

Conversation

ajkyffin
Copy link
Member

Merges main into this branch. Only the last commit needs to be reviewed.

  • Split into a build stage and an install/run stage
  • Use the python:3-alpine base image
  • Run as a non-root user
  • Add an entrypoint script that sets values in config.yaml from environment variables

antolinos and others added 30 commits May 19, 2022 13:40
This fixes the problem with limit when it is not a number
Automatically generated by python-semantic-release
Automatically generated by python-semantic-release
BREAKING CHANGE: Remove support for json configuration files
@ajkyffin ajkyffin requested a review from VKTB February 20, 2023 12:00
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 94.47% // Head: 42.30% // Decreases project coverage by -52.18% ⚠️

Coverage data is based on head (e7630dc) compared to base (6c7332e).
Patch coverage: 98.22% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           k8s-deployment     #402       +/-   ##
===================================================
- Coverage           94.47%   42.30%   -52.18%     
===================================================
  Files                  39       39               
  Lines                3114     3319      +205     
  Branches              311      310        -1     
===================================================
- Hits                 2942     1404     -1538     
- Misses                144     1907     +1763     
+ Partials               28        8       -20     
Impacted Files Coverage Δ
datagateway_api/src/datagateway_api/backends.py 0.00% <ø> (-100.00%) ⬇️
...ateway_api/src/datagateway_api/database/helpers.py 0.00% <0.00%> (-77.22%) ⬇️
...atagateway_api/src/datagateway_api/icat/helpers.py 0.00% <0.00%> (-94.58%) ⬇️
...ay_api/src/datagateway_api/query_filter_factory.py 30.30% <ø> (-69.70%) ⬇️
...api/src/resources/entities/entity_endpoint_dict.py 100.00% <ø> (ø)
datagateway_api/src/search_api/filters.py 0.00% <0.00%> (-98.91%) ⬇️
datagateway_api/src/common/config.py 98.68% <100.00%> (-1.32%) ⬇️
...gateway_api/src/datagateway_api/database/models.py 94.32% <100.00%> (-2.13%) ⬇️
datagateway_api/src/search_api/models.py 99.52% <100.00%> (+<0.01%) ⬆️
datagateway_api/src/common/constants.py 0.00% <0.00%> (-100.00%) ⬇️
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated
COPY datagateway_api ./datagateway_api

# Install & run stage
FROM python:3-alpine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to pin the version of Python to prevent unexpected breakages in future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in dfb54ba

@ajkyffin ajkyffin requested a review from VKTB February 21, 2023 14:33
@ajkyffin ajkyffin merged commit bf5e283 into k8s-deployment Feb 21, 2023
@ajkyffin ajkyffin deleted the update-dockerfile branch February 21, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants