Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSEGOG-300 Add mongoimport back to GitHub Actions #97

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

MRichards99
Copy link
Collaborator

With the introduction of running tests on Python 3.10 & 3.11, Ubuntu 22.04 runners need to be used. In these runners, Ubuntu have removed mongodb from being installed in 22.04, hence the Actions runner image also not having it. We use the supercharge/mongodb-github-action@1.7.0 action to start the database as they are "available from within the MongoDB docker container. But not directly on the 22.04 host" (supercharge/mongodb-github-action#39 (comment)).

Someone has found a solution to install mongosh on their CI (see actions/runner-images#6626 (comment)) and I've adapted their commands to install mongoimport instead). I've made use of mongoimport in the ingest_hdf.py script as it serves as a good test that it works. I haven't entirely reverted Patrick's work (i.e. go back to running the command separately from the script) as I think it's better to keep it in the script (less commands that the developer needs to run) and the simulated data script will import the test users so it's nice to keep them consistent where possible.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (03c9d39) to head (02c8579).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files          45       45           
  Lines        2153     2153           
  Branches      164      164           
=======================================
  Hits         1791     1791           
  Misses        329      329           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MRichards99 MRichards99 merged commit 4a6691b into main Feb 27, 2024
16 checks passed
@MRichards99 MRichards99 deleted the DSEGOG-300-mongoimport-ci branch February 27, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants