-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-std implementation #167
Open
dharjeezy
wants to merge
37
commits into
ralexstokes:main
Choose a base branch
from
polytope-labs:dami/no-std-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 30 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
779a1e7
started no-std support
dharjeezy 3e66ff7
invalid operation error
dharjeezy 0b79485
introduce prelude which contains the no_std imports
dharjeezy 7492dde
transform all state_transition errors to no_std
dharjeezy 8221123
introduce BTreeSet and BTreeMap in prelude
dharjeezy ac1b571
further no_std imports in prelude
dharjeezy cd52ded
introduce hashbrown crate
dharjeezy 0d05be0
serde features on structs
dharjeezy 54f8133
make use of milagro_bls for no_std support
dharjeezy eeb1d5e
make ssz-rs default feature
dharjeezy 8849fcb
fix on comments
dharjeezy 2c0d3dd
use signature for aggregate verify
dharjeezy 32883ab
use signature for aggregate verify
dharjeezy 04f9bcc
introduce key validation failed
dharjeezy a6c3687
build successful in std and no_std context
dharjeezy 1f0e6e2
all test passes
dharjeezy 71710e9
remove duplication
dharjeezy df115f5
implement Eq and PartialEq traits for DomainType enum
dharjeezy 7875009
remove saturating_div
dharjeezy 33f236a
Merge branch 'main' of https://github.com/polytope-labs/ethereum-cons…
dharjeezy 8c50522
merge changes
dharjeezy e5c0d21
fix warnings
dharjeezy 2f46baf
remove prelude.rs
dharjeezy 248b5d1
remove excess clones
Wizdave97 63b847d
introduce default macro for execution payload
dharjeezy 9177be3
remove default
dharjeezy 6b971e2
include default and alias
dharjeezy 918fda3
use rev
dharjeezy a850739
Merge branch 'main' of https://github.com/polytope-labs/ethereum-cons…
dharjeezy 8be43ea
no-std for capella fork
dharjeezy 9862cab
change ssz-rs repo temporarily
dharjeezy e334085
Merge branch 'main' of https://github.com/polytope-labs/ethereum-cons…
dharjeezy 6b7f33d
merge conflict fixed
dharjeezy b6ced43
fix std and no std builds
Wizdave97 23cd342
extra fixes
Wizdave97 bd19d7c
point ssz-rs to original crate
Wizdave97 34bb57f
point ssz-rs to polytope labs
Wizdave97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious what is the purpose of this? It seems to be broken at the moment if the "serde" feature is not enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dharjeezy why is there a serde feature flag here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, our target compilation is
wasm32-unknown-unknown
I had to include the feature flag because of that else it errors out
@Wizdave97 @willemolding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collecting into a dynamic type like a Vec might work better in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better to use
#[cfg(target_arch = "wasm32")]
if it is a wasm specific thing? As it stands it errors out building for x86 with serde disabledThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait an even better solution is to remove the intermediate variable entirely e.g.
This will build either way regardless of the size of a u64 on the given target