Skip to content

Commit

Permalink
fix(cmd): update Ledger supported algorithms to only consist of `EthS…
Browse files Browse the repository at this point in the history
…ecp256k1` (evmos#1165)

* fix: update Ledger supported algorithms to consist of `EthSecp256k1`

* add changelog entry

* correct PR number in changelog entry

* Update CHANGELOG.md

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Co-authored-by: MalteHerrmann <malte@evmos.org>
  • Loading branch information
4 people authored Dec 22, 2022
1 parent 58c01c2 commit bc62043
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Bug Fixes

- (app) [#1165](https://github.com/evmos/evmos/pull/1165) Update Ledger supported algorithms to only consist of `EthSecp256k1`
- (cmd) [#1172](https://github.com/evmos/evmos/pull/1172) Update default node snapshot interval to `5000`
- (cmd) [\#1120](https://github.com/evmos/evmos/pull/1120) Fix snapshot configuration
- (app) [\#1118](https://github.com/evmos/evmos/pull/1118) Setup gRPC node service with the application.
Expand Down
3 changes: 1 addition & 2 deletions crypto/keyring/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
cosmosLedger "github.com/cosmos/cosmos-sdk/crypto/ledger"
"github.com/cosmos/cosmos-sdk/crypto/types"

sdkhd "github.com/cosmos/cosmos-sdk/crypto/hd"
"github.com/evmos/ethermint/crypto/ethsecp256k1"
"github.com/evmos/ethermint/crypto/hd"
"github.com/evmos/evmos-ledger-go/ledger"
Expand All @@ -21,7 +20,7 @@ var (
// SupportedAlgorithmsLedger defines the list of signing algorithms used on Evmos for the Ledger device:
// - secp256k1 (in order to comply with Cosmos SDK)
// The Ledger derivation function is responsible for all signing and address generation.
SupportedAlgorithmsLedger = keyring.SigningAlgoList{sdkhd.Secp256k1}
SupportedAlgorithmsLedger = keyring.SigningAlgoList{hd.EthSecp256k1}
// LedgerDerivation defines the Evmos Ledger Go derivation (Ethereum app with EIP-712 signing)
LedgerDerivation = ledger.EvmosLedgerDerivation()
// CreatePubkey uses the ethsecp256k1 pubkey with Ethereum address generation and keccak hashing
Expand Down

0 comments on commit bc62043

Please sign in to comment.