Skip to content

Commit

Permalink
fix(eslint-config): remove no-secrets rule
Browse files Browse the repository at this point in the history
  • Loading branch information
andrepolischuk committed Sep 4, 2024
1 parent 7372a30 commit 8688d92
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
6 changes: 2 additions & 4 deletions packages/eslint-config/js.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = {
'plugin:security/recommended-legacy',
'prettier'
],
plugins: ['promise', 'unicorn', 'todo-with-label', 'no-secrets'],
plugins: ['promise', 'unicorn', 'todo-with-label'],
rules: {
'no-multiple-empty-lines': ['error', {max: 1}],
'no-empty': ['error', {allowEmptyCatch: true}],
Expand Down Expand Up @@ -235,7 +235,6 @@ module.exports = {
'security/detect-pseudoRandomBytes': 'error',
'security/detect-unsafe-regex': 'off',
'security/detect-bidi-characters': 'error',
'no-secrets/no-secrets': 'error',
'todo-with-label/has-valid-pattern': [
'error',
{
Expand Down Expand Up @@ -263,8 +262,7 @@ module.exports = {
'max-classes-per-file': 'off',
'max-nested-callbacks': 'off',
'sonarjs/no-duplicate-string': 'off',
'sonarjs/no-identical-functions': 'off',
'no-secrets/no-secrets': 'off'
'sonarjs/no-identical-functions': 'off'
}
}
],
Expand Down
1 change: 0 additions & 1 deletion packages/eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"eslint-import-resolver-webpack": "^0.13.8",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jsx-a11y": "^6.8.0",
"eslint-plugin-no-secrets": "^1.0.2",
"eslint-plugin-promise": "^6.1.1",
"eslint-plugin-react": "^7.28.0",
"eslint-plugin-react-hooks": "^4.3.0",
Expand Down
5 changes: 0 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2765,11 +2765,6 @@ eslint-plugin-jsx-a11y@^6.8.0:
object.entries "^1.1.7"
object.fromentries "^2.0.7"

eslint-plugin-no-secrets@^1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/eslint-plugin-no-secrets/-/eslint-plugin-no-secrets-1.0.2.tgz#a3860d547ee3be96adc002ec72ac1c6c875278aa"
integrity sha512-lXjGcPS6ZMxAouYWsuX5NGsLlOWQ5c+YFHHZFECzRCZIssYQgWVPINgZqAU7caquB32MoEAL+dXRQNDBX0fgwQ==

eslint-plugin-promise@^6.1.1:
version "6.1.1"
resolved "https://registry.yarnpkg.com/eslint-plugin-promise/-/eslint-plugin-promise-6.1.1.tgz#269a3e2772f62875661220631bd4dafcb4083816"
Expand Down

0 comments on commit 8688d92

Please sign in to comment.